
Current AP spec demands anonymous objects to have an id value,
but explicitly set it to JSON null. Howeveras it turns out this is
incompatible with JSON-LD requiring `@id` to be a string and thus AP
spec is incompatible iwth the Ativity Streams spec it is based on.
This is an issue for (the few) AP implementers actually performing
JSON-LD processing, like IceShrimp.NET.
This was uncovered by IceShrimp.NET’s zotan due to our adoption of
anonymous objects for emoj in f101886709
.
The issues is being discussed by W3C, and will most likely be resolved
via an errata redefining anonymous objects to completely omit the id
field just like transient objects already do. See:
https://github.com/w3c/activitypub/issues/476
Fixes: https://akkoma.dev/AkkomaGang/akkoma/issues/848
182 lines
6 KiB
Elixir
182 lines
6 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.ActivityPub.UserViewTest do
|
|
use Pleroma.DataCase, async: true
|
|
import Pleroma.Factory
|
|
|
|
alias Pleroma.User
|
|
alias Pleroma.Web.ActivityPub.UserView
|
|
alias Pleroma.Web.CommonAPI
|
|
|
|
test "Renders a user, including the public key" do
|
|
user =
|
|
insert(:user)
|
|
|> with_signing_key()
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
|
|
assert result["id"] == user.ap_id
|
|
assert result["preferredUsername"] == user.nickname
|
|
|
|
assert String.contains?(result["publicKey"]["publicKeyPem"], "BEGIN PUBLIC KEY")
|
|
end
|
|
|
|
test "Renders profile fields" do
|
|
fields = [
|
|
%{"name" => "foo", "value" => "bar"}
|
|
]
|
|
|
|
{:ok, user} =
|
|
insert(:user)
|
|
|> User.update_changeset(%{fields: fields})
|
|
|> User.update_and_set_cache()
|
|
|
|
assert %{
|
|
"attachment" => [%{"name" => "foo", "type" => "PropertyValue", "value" => "bar"}]
|
|
} = UserView.render("user.json", %{user: user})
|
|
end
|
|
|
|
test "Renders with emoji tags" do
|
|
user =
|
|
insert(:user, emoji: %{"bib" => "/test"})
|
|
|> with_signing_key()
|
|
|
|
assert %{
|
|
"tag" => [
|
|
%{
|
|
"icon" => %{"type" => "Image", "url" => "/test"},
|
|
"name" => ":bib:",
|
|
"type" => "Emoji",
|
|
"updated" => "1970-01-01T00:00:00Z"
|
|
}
|
|
]
|
|
} = UserView.render("user.json", %{user: user})
|
|
end
|
|
|
|
test "Does not add an avatar image if the user hasn't set one" do
|
|
user = insert(:user)
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
refute result["icon"]
|
|
refute result["image"]
|
|
refute result["backgroundUrl"]
|
|
|
|
user =
|
|
insert(:user,
|
|
avatar: %{"url" => [%{"href" => "https://someurl"}]},
|
|
banner: %{"url" => [%{"href" => "https://somebanner"}]},
|
|
background: %{"url" => [%{"href" => "https://somebackground"}]}
|
|
)
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
assert result["icon"]["url"] == "https://someurl"
|
|
assert result["image"]["url"] == "https://somebanner"
|
|
assert result["backgroundUrl"]["url"] == "https://somebackground"
|
|
end
|
|
|
|
test "renders an invisible user with the invisible property set to true" do
|
|
user =
|
|
insert(:user, invisible: true)
|
|
|> with_signing_key()
|
|
|
|
assert %{"invisible" => true} = UserView.render("service.json", %{user: user})
|
|
end
|
|
|
|
test "service has a few essential fields" do
|
|
user =
|
|
insert(:user)
|
|
|> with_signing_key()
|
|
|
|
result = UserView.render("service.json", %{user: user})
|
|
assert result["id"]
|
|
assert result["type"] == "Application"
|
|
assert result["inbox"]
|
|
assert result["outbox"]
|
|
end
|
|
|
|
test "renders AKAs" do
|
|
akas = ["https://i.tusooa.xyz/users/test-pleroma"]
|
|
user = insert(:user, also_known_as: akas)
|
|
assert %{"alsoKnownAs" => ^akas} = UserView.render("user.json", %{user: user})
|
|
end
|
|
|
|
describe "endpoints" do
|
|
test "local users have a usable endpoints structure" do
|
|
user = insert(:user)
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
|
|
assert result["id"] == user.ap_id
|
|
|
|
%{
|
|
"sharedInbox" => _,
|
|
"oauthAuthorizationEndpoint" => _,
|
|
"oauthRegistrationEndpoint" => _,
|
|
"oauthTokenEndpoint" => _
|
|
} = result["endpoints"]
|
|
end
|
|
|
|
test "remote users have an empty endpoints structure" do
|
|
user = insert(:user, local: false)
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
|
|
assert result["id"] == user.ap_id
|
|
assert result["endpoints"] == %{}
|
|
end
|
|
|
|
test "instance users do not expose oAuth endpoints" do
|
|
user =
|
|
insert(:user, nickname: nil, local: true)
|
|
|> with_signing_key()
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
|
|
refute result["endpoints"]["oauthAuthorizationEndpoint"]
|
|
refute result["endpoints"]["oauthRegistrationEndpoint"]
|
|
refute result["endpoints"]["oauthTokenEndpoint"]
|
|
end
|
|
end
|
|
|
|
describe "followers" do
|
|
test "sets totalItems to zero when followers are hidden" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
{:ok, _other_user, user, _activity} = CommonAPI.follow(other_user, user)
|
|
assert %{"totalItems" => 1} = UserView.render("followers.json", %{user: user})
|
|
user = Map.merge(user, %{hide_followers_count: true, hide_followers: true})
|
|
refute UserView.render("followers.json", %{user: user}) |> Map.has_key?("totalItems")
|
|
end
|
|
|
|
test "sets correct totalItems when followers are hidden but the follower counter is not" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
{:ok, _other_user, user, _activity} = CommonAPI.follow(other_user, user)
|
|
assert %{"totalItems" => 1} = UserView.render("followers.json", %{user: user})
|
|
user = Map.merge(user, %{hide_followers_count: false, hide_followers: true})
|
|
assert %{"totalItems" => 1} = UserView.render("followers.json", %{user: user})
|
|
end
|
|
end
|
|
|
|
describe "following" do
|
|
test "sets totalItems to zero when follows are hidden" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
{:ok, user, _other_user, _activity} = CommonAPI.follow(user, other_user)
|
|
assert %{"totalItems" => 1} = UserView.render("following.json", %{user: user})
|
|
user = Map.merge(user, %{hide_follows_count: true, hide_follows: true})
|
|
assert %{"totalItems" => 0} = UserView.render("following.json", %{user: user})
|
|
end
|
|
|
|
test "sets correct totalItems when follows are hidden but the follow counter is not" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
{:ok, user, _other_user, _activity} = CommonAPI.follow(user, other_user)
|
|
assert %{"totalItems" => 1} = UserView.render("following.json", %{user: user})
|
|
user = Map.merge(user, %{hide_follows_count: false, hide_follows: true})
|
|
assert %{"totalItems" => 1} = UserView.render("following.json", %{user: user})
|
|
end
|
|
end
|
|
end
|