46148c0825
And for now treat partial fetches as a success, since for all
current users partial collection data is better than no data at all.
If an error occurred while fetching a page, this previously
returned a bogus {:ok, {:error, _}} success, causing the error
to be attached to the object as an reply list subsequently
leading to the whole post getting rejected during validation.
Also the pinned collection caller did not actually handle
the preexisting error case resulting in process crashes.
96 lines
3.1 KiB
Elixir
96 lines
3.1 KiB
Elixir
# Akkoma: The cooler fediverse server
|
|
# Copyright © 2022- Akkoma Authors <https://akkoma.dev/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Akkoma.Collections.Fetcher do
|
|
@moduledoc """
|
|
Activitypub Collections fetching functions
|
|
see: https://www.w3.org/TR/activitystreams-core/#paging
|
|
"""
|
|
alias Pleroma.Object.Fetcher
|
|
alias Pleroma.Config
|
|
require Logger
|
|
|
|
@spec fetch_collection(String.t() | map()) :: {:ok, [Pleroma.Object.t()]} | {:error, any()}
|
|
def fetch_collection(ap_id) when is_binary(ap_id) do
|
|
with {:ok, page} <- Fetcher.fetch_and_contain_remote_object_from_id(ap_id) do
|
|
partial_as_success(objects_from_collection(page))
|
|
else
|
|
e ->
|
|
Logger.error("Could not fetch collection #{ap_id} - #{inspect(e)}")
|
|
e
|
|
end
|
|
end
|
|
|
|
def fetch_collection(%{"type" => type} = page)
|
|
when type in ["Collection", "OrderedCollection", "CollectionPage", "OrderedCollectionPage"] do
|
|
partial_as_success(objects_from_collection(page))
|
|
end
|
|
|
|
defp partial_as_success({:partial, items}), do: {:ok, items}
|
|
defp partial_as_success(res), do: res
|
|
|
|
defp items_in_page(%{"type" => type, "orderedItems" => items})
|
|
when is_list(items) and type in ["OrderedCollection", "OrderedCollectionPage"],
|
|
do: items
|
|
|
|
defp items_in_page(%{"type" => type, "items" => items})
|
|
when is_list(items) and type in ["Collection", "CollectionPage"],
|
|
do: items
|
|
|
|
defp objects_from_collection(%{"type" => type, "orderedItems" => items} = page)
|
|
when is_list(items) and type in ["OrderedCollection", "OrderedCollectionPage"],
|
|
do: maybe_next_page(page, items)
|
|
|
|
defp objects_from_collection(%{"type" => type, "items" => items} = page)
|
|
when is_list(items) and type in ["Collection", "CollectionPage"],
|
|
do: maybe_next_page(page, items)
|
|
|
|
defp objects_from_collection(%{"type" => type, "first" => first})
|
|
when is_binary(first) and type in ["Collection", "OrderedCollection"] do
|
|
fetch_page_items(first)
|
|
end
|
|
|
|
defp objects_from_collection(%{"type" => type, "first" => %{"id" => id}})
|
|
when is_binary(id) and type in ["Collection", "OrderedCollection"] do
|
|
fetch_page_items(id)
|
|
end
|
|
|
|
defp objects_from_collection(_page), do: {:ok, []}
|
|
|
|
defp fetch_page_items(id, items \\ []) do
|
|
if Enum.count(items) >= Config.get([:activitypub, :max_collection_objects]) do
|
|
{:ok, items}
|
|
else
|
|
with {:ok, page} <- Fetcher.fetch_and_contain_remote_object_from_id(id) do
|
|
objects = items_in_page(page)
|
|
|
|
if Enum.count(objects) > 0 do
|
|
maybe_next_page(page, items ++ objects)
|
|
else
|
|
{:ok, items}
|
|
end
|
|
else
|
|
{:error, :not_found} ->
|
|
{:ok, items}
|
|
|
|
{:error, :forbidden} ->
|
|
{:ok, items}
|
|
|
|
{:error, error} ->
|
|
Logger.error("Could not fetch page #{id} - #{inspect(error)}")
|
|
|
|
case items do
|
|
[] -> {:error, error}
|
|
_ -> {:partial, items}
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
defp maybe_next_page(%{"next" => id}, items) when is_binary(id) do
|
|
fetch_page_items(id, items)
|
|
end
|
|
|
|
defp maybe_next_page(_, items), do: {:ok, items}
|
|
end
|