
CUrrently internal actors are supposed to be identified in the database by either a NULL nickname or a nickname prefixed by "internal.". For old installations this is true, but only if they were created over five years ago before70410dfafd
. Newer installations will use "relay" as the nickname of the realy actor causing ii to be treated as a regular user. In particular this means all installations in the last five years never made use of the reduced endpoint case, thus it is dropped. Simplify this distinction by properly marking internal actors asa an Application type in the database. This was already implemented before by ilja in https://akkoma.dev/AkkomaGang/akkoma/pulls/457 but accidentally reverted during a translation update ineba3cce77b
. This commit effectively restores this patch together with further changes. Also service actors unconditionally expose follow* collections atm, eventhough the internal fetch actor doesn't actually implement them. Since they are optional per spec and with Mastodon omitting them too for its instance actor proving the practical viability, we should just omit them. The relay actor however should continue to expose such collections and they are properly implemented here. Here too we now just use the values or their absence in the database. We do not have any other internal.* actors besides fetch atm. Fixes: https://akkoma.dev/AkkomaGang/akkoma/issues/855 Co-authored-by: ilja space <git@ilja.space>
170 lines
5.6 KiB
Elixir
170 lines
5.6 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.ActivityPub.UserViewTest do
|
|
use Pleroma.DataCase, async: true
|
|
import Pleroma.Factory
|
|
|
|
alias Pleroma.User
|
|
alias Pleroma.Web.ActivityPub.UserView
|
|
alias Pleroma.Web.CommonAPI
|
|
|
|
test "Renders a user, including the public key" do
|
|
user =
|
|
insert(:user)
|
|
|> with_signing_key()
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
|
|
assert result["id"] == user.ap_id
|
|
assert result["preferredUsername"] == user.nickname
|
|
|
|
assert String.contains?(result["publicKey"]["publicKeyPem"], "BEGIN PUBLIC KEY")
|
|
end
|
|
|
|
test "Renders profile fields" do
|
|
fields = [
|
|
%{"name" => "foo", "value" => "bar"}
|
|
]
|
|
|
|
{:ok, user} =
|
|
insert(:user)
|
|
|> User.update_changeset(%{fields: fields})
|
|
|> User.update_and_set_cache()
|
|
|
|
assert %{
|
|
"attachment" => [%{"name" => "foo", "type" => "PropertyValue", "value" => "bar"}]
|
|
} = UserView.render("user.json", %{user: user})
|
|
end
|
|
|
|
test "Renders with emoji tags" do
|
|
user =
|
|
insert(:user, emoji: %{"bib" => "/test"})
|
|
|> with_signing_key()
|
|
|
|
assert %{
|
|
"tag" => [
|
|
%{
|
|
"icon" => %{"type" => "Image", "url" => "/test"},
|
|
"name" => ":bib:",
|
|
"type" => "Emoji",
|
|
"updated" => "1970-01-01T00:00:00Z"
|
|
}
|
|
]
|
|
} = UserView.render("user.json", %{user: user})
|
|
end
|
|
|
|
test "Does not add an avatar image if the user hasn't set one" do
|
|
user = insert(:user)
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
refute result["icon"]
|
|
refute result["image"]
|
|
refute result["backgroundUrl"]
|
|
|
|
user =
|
|
insert(:user,
|
|
avatar: %{"url" => [%{"href" => "https://someurl"}]},
|
|
banner: %{"url" => [%{"href" => "https://somebanner"}]},
|
|
background: %{"url" => [%{"href" => "https://somebackground"}]}
|
|
)
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
assert result["icon"]["url"] == "https://someurl"
|
|
assert result["image"]["url"] == "https://somebanner"
|
|
assert result["backgroundUrl"]["url"] == "https://somebackground"
|
|
end
|
|
|
|
test "renders an invisible user with the invisible property set to true" do
|
|
user =
|
|
insert(:user, invisible: true)
|
|
|> with_signing_key()
|
|
|
|
assert %{"invisible" => true} = UserView.render("service.json", %{user: user})
|
|
end
|
|
|
|
test "service has a few essential fields" do
|
|
user =
|
|
insert(:user)
|
|
|> with_signing_key()
|
|
|
|
result = UserView.render("service.json", %{user: user})
|
|
assert result["id"]
|
|
assert result["type"] == "Application"
|
|
assert result["inbox"]
|
|
assert result["outbox"]
|
|
end
|
|
|
|
test "renders AKAs" do
|
|
akas = ["https://i.tusooa.xyz/users/test-pleroma"]
|
|
user = insert(:user, also_known_as: akas)
|
|
assert %{"alsoKnownAs" => ^akas} = UserView.render("user.json", %{user: user})
|
|
end
|
|
|
|
describe "endpoints" do
|
|
test "local users have a usable endpoints structure" do
|
|
user = insert(:user)
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
|
|
assert result["id"] == user.ap_id
|
|
|
|
%{
|
|
"sharedInbox" => _,
|
|
"oauthAuthorizationEndpoint" => _,
|
|
"oauthRegistrationEndpoint" => _,
|
|
"oauthTokenEndpoint" => _
|
|
} = result["endpoints"]
|
|
end
|
|
|
|
test "remote users have an empty endpoints structure" do
|
|
user = insert(:user, local: false)
|
|
|
|
result = UserView.render("user.json", %{user: user})
|
|
|
|
assert result["id"] == user.ap_id
|
|
assert result["endpoints"] == %{}
|
|
end
|
|
end
|
|
|
|
describe "followers" do
|
|
test "sets totalItems to zero when followers are hidden" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
{:ok, _other_user, user, _activity} = CommonAPI.follow(other_user, user)
|
|
assert %{"totalItems" => 1} = UserView.render("followers.json", %{user: user})
|
|
user = Map.merge(user, %{hide_followers_count: true, hide_followers: true})
|
|
refute UserView.render("followers.json", %{user: user}) |> Map.has_key?("totalItems")
|
|
end
|
|
|
|
test "sets correct totalItems when followers are hidden but the follower counter is not" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
{:ok, _other_user, user, _activity} = CommonAPI.follow(other_user, user)
|
|
assert %{"totalItems" => 1} = UserView.render("followers.json", %{user: user})
|
|
user = Map.merge(user, %{hide_followers_count: false, hide_followers: true})
|
|
assert %{"totalItems" => 1} = UserView.render("followers.json", %{user: user})
|
|
end
|
|
end
|
|
|
|
describe "following" do
|
|
test "sets totalItems to zero when follows are hidden" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
{:ok, user, _other_user, _activity} = CommonAPI.follow(user, other_user)
|
|
assert %{"totalItems" => 1} = UserView.render("following.json", %{user: user})
|
|
user = Map.merge(user, %{hide_follows_count: true, hide_follows: true})
|
|
assert %{"totalItems" => 0} = UserView.render("following.json", %{user: user})
|
|
end
|
|
|
|
test "sets correct totalItems when follows are hidden but the follow counter is not" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
{:ok, user, _other_user, _activity} = CommonAPI.follow(user, other_user)
|
|
assert %{"totalItems" => 1} = UserView.render("following.json", %{user: user})
|
|
user = Map.merge(user, %{hide_follows_count: false, hide_follows: true})
|
|
assert %{"totalItems" => 1} = UserView.render("following.json", %{user: user})
|
|
end
|
|
end
|
|
end
|