8dad70e8e7
This property was introduced as a way to gauge whether and how much enabling authfetch might break passive federation in https://akkoma.dev/AkkomaGang/akkoma/pulls/312. However, with the db field defaulting to false, there’s no distinction between instances without valid signatures and those which just never attempted to fetch anything from the local instance. Furthermore, this was never exposed anywhere and required manually checking the database or cachex state via a remote shell. Given the above it appears this doesn't actually provide anything useful, thus drop it.
114 lines
3.4 KiB
Elixir
114 lines
3.4 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.Plugs.HTTPSignaturePlugTest do
|
|
use Pleroma.Web.ConnCase, async: false
|
|
@moduletag :mocked
|
|
import Pleroma.Factory
|
|
alias Pleroma.Web.Plugs.HTTPSignaturePlug
|
|
|
|
import Plug.Conn
|
|
import Phoenix.Controller, only: [put_format: 2]
|
|
import Mock
|
|
|
|
@user_ap_id "http://mastodon.example.org/users/admin"
|
|
|
|
setup do
|
|
user =
|
|
:user
|
|
|> insert(%{ap_id: "http://mastodon.example.org/users/admin"})
|
|
|> with_signing_key(%{key_id: "http://mastodon.example.org/users/admin#main-key"})
|
|
|
|
{:ok, %{user: user}}
|
|
end
|
|
|
|
setup_with_mocks([
|
|
{HTTPSignatures, [],
|
|
[
|
|
validate_conn: fn conn, _ ->
|
|
if Map.get(conn.assigns, :valid_signature, true) do
|
|
{:ok, user} = Pleroma.User.get_or_fetch_by_ap_id(@user_ap_id)
|
|
{:ok, %HTTPSignatures.HTTPKey{key: "aaa", user_data: %{"key_user" => user}}}
|
|
else
|
|
{:error, :wrong_signature}
|
|
end
|
|
end
|
|
]}
|
|
]) do
|
|
:ok
|
|
end
|
|
|
|
test "it call HTTPSignatures to check validity if the actor signed it", %{user: user} do
|
|
params = %{"actor" => user.ap_id}
|
|
conn = build_conn(:get, "/doesntmattter", params)
|
|
|
|
conn =
|
|
conn
|
|
|> put_req_header(
|
|
"signature",
|
|
"keyId=\"#{user.signing_key.key_id}\""
|
|
)
|
|
|> put_format("activity+json")
|
|
|> HTTPSignaturePlug.call(%{})
|
|
|
|
assert conn.assigns.valid_signature == true
|
|
assert conn.assigns.signature_user.ap_id == params["actor"]
|
|
assert conn.halted == false
|
|
assert called(HTTPSignatures.validate_conn(:_, :_))
|
|
end
|
|
|
|
describe "requires a signature when `authorized_fetch_mode` is enabled" do
|
|
setup do
|
|
clear_config([:activitypub, :authorized_fetch_mode], true)
|
|
|
|
params = %{"actor" => "http://mastodon.example.org/users/admin"}
|
|
conn = build_conn(:get, "/doesntmattter", params) |> put_format("activity+json")
|
|
|
|
[conn: conn]
|
|
end
|
|
|
|
test "and signature is present and incorrect", %{conn: conn} do
|
|
conn =
|
|
conn
|
|
|> assign(:valid_signature, false)
|
|
|> put_req_header(
|
|
"signature",
|
|
"keyId=\"http://mastodon.example.org/users/admin#main-key"
|
|
)
|
|
|> HTTPSignaturePlug.call(%{})
|
|
|
|
assert conn.assigns.valid_signature == false
|
|
assert called(HTTPSignatures.validate_conn(:_, :_))
|
|
end
|
|
|
|
test "and signature is correct", %{conn: conn} do
|
|
conn =
|
|
conn
|
|
|> put_req_header(
|
|
"signature",
|
|
"keyId=\"http://mastodon.example.org/users/admin#main-key"
|
|
)
|
|
|> HTTPSignaturePlug.call(%{})
|
|
|
|
assert conn.assigns.valid_signature == true
|
|
assert called(HTTPSignatures.validate_conn(:_, :_))
|
|
end
|
|
|
|
test "and halts the connection when `signature` header is not present", %{conn: conn} do
|
|
conn = HTTPSignaturePlug.call(conn, %{})
|
|
assert conn.assigns[:valid_signature] == nil
|
|
end
|
|
end
|
|
|
|
test "aliases redirected /object endpoints", _ do
|
|
obj = insert(:note)
|
|
act = insert(:note_activity, note: obj)
|
|
params = %{"actor" => "someparam"}
|
|
path = URI.parse(obj.data["id"]).path
|
|
conn = build_conn(:get, path, params)
|
|
|
|
assert ["/notice/#{act.id}", "/notice/#{act.id}?actor=someparam"] ==
|
|
HTTPSignaturePlug.route_aliases(conn)
|
|
end
|
|
end
|