2fee79e1f5
:discard marks jobs as "discarded", i.e. jobs which permanently failed
due to e.g. exhausting all retries or explicitly being discared due to a
fatal error.
:cancel marks jobs as "cancelled" which does not imply failure.
While neither method counts as a job "exception" in the set of
telemetries we currently export via Prometheus, the different state
is visible in the (not-exported) metadata of oban job telemetry.
We can use handlers of those events to build bespoke statistics.
Ideally we'd like to distinguish in the receiver worker between
"invalid" and "already present or delete of unknown" documents,
but this is cumbersome to get get right with a list of
free-form, human-readable descriptions oof the violated constraints.
For now, just count both as an fatal error.
# but that is cumbersome to get right with a list of string error descriptions
61 lines
1.8 KiB
Elixir
61 lines
1.8 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Workers.ReceiverWorkerTest do
|
|
use Pleroma.DataCase, async: false
|
|
use Oban.Testing, repo: Pleroma.Repo
|
|
@moduletag :mocked
|
|
|
|
import ExUnit.CaptureLog
|
|
import Mock
|
|
import Pleroma.Factory
|
|
|
|
alias Pleroma.Web.ActivityPub.Utils
|
|
alias Pleroma.Workers.ReceiverWorker
|
|
|
|
test "it ignores MRF reject" do
|
|
user = insert(:user, local: false)
|
|
params = insert(:note, user: user, data: %{"id" => user.ap_id <> "/note/1"}).data
|
|
|
|
with_mock Pleroma.Web.ActivityPub.Transmogrifier,
|
|
handle_incoming: fn _ -> {:reject, "MRF"} end do
|
|
assert {:cancel, "MRF"} =
|
|
ReceiverWorker.perform(%Oban.Job{
|
|
args: %{"op" => "incoming_ap_doc", "params" => params}
|
|
})
|
|
end
|
|
end
|
|
|
|
test "it errors on receiving local documents" do
|
|
actor = insert(:user, local: true)
|
|
recipient = insert(:user, local: true)
|
|
|
|
to = [recipient.ap_id]
|
|
cc = []
|
|
|
|
params = %{
|
|
"@context" => ["https://www.w3.org/ns/activitystreams"],
|
|
"type" => "Create",
|
|
"id" => Utils.generate_activity_id(),
|
|
"to" => to,
|
|
"cc" => cc,
|
|
"actor" => actor.ap_id,
|
|
"object" => %{
|
|
"type" => "Note",
|
|
"to" => to,
|
|
"cc" => cc,
|
|
"content" => "It's a note",
|
|
"attributedTo" => actor.ap_id,
|
|
"id" => Utils.generate_object_id()
|
|
}
|
|
}
|
|
|
|
assert capture_log(fn ->
|
|
assert {:discard, :origin_containment_failed} ==
|
|
ReceiverWorker.perform(%Oban.Job{
|
|
args: %{"op" => "incoming_ap_doc", "params" => params}
|
|
})
|
|
end) =~ "[alert] Received incoming AP doc with valid signature for local actor"
|
|
end
|
|
end
|