tests: simplify object fetching and containment tests
This commit is contained in:
		
							parent
							
								
									597cb8897b
								
							
						
					
					
						commit
						af9aa8e358
					
				
					 2 changed files with 4 additions and 19 deletions
				
			
		| 
						 | 
				
			
			@ -65,7 +65,7 @@ test "users cannot be collided through fake direction spoofing attempts" do
 | 
			
		|||
      assert capture_log(fn ->
 | 
			
		||||
               {:error, _} = User.get_or_fetch_by_ap_id("https://n1u.moe/users/rye")
 | 
			
		||||
             end) =~
 | 
			
		||||
               "[error] Could not decode user at fetch https://n1u.moe/users/rye, {:error, :error}"
 | 
			
		||||
               "[error] Could not decode user at fetch https://n1u.moe/users/rye"
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -27,31 +27,16 @@ defmodule Pleroma.Object.FetcherTest do
 | 
			
		|||
  end
 | 
			
		||||
 | 
			
		||||
  describe "actor origin containment" do
 | 
			
		||||
    test_with_mock "it rejects objects with a bogus origin",
 | 
			
		||||
                   Pleroma.Web.OStatus,
 | 
			
		||||
                   [:passthrough],
 | 
			
		||||
                   [] do
 | 
			
		||||
    test "it rejects objects with a bogus origin" do
 | 
			
		||||
      {:error, _} = Fetcher.fetch_object_from_id("https://info.pleroma.site/activity.json")
 | 
			
		||||
 | 
			
		||||
      refute called(Pleroma.Web.OStatus.fetch_activity_from_url(:_))
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    test_with_mock "it rejects objects when attributedTo is wrong (variant 1)",
 | 
			
		||||
                   Pleroma.Web.OStatus,
 | 
			
		||||
                   [:passthrough],
 | 
			
		||||
                   [] do
 | 
			
		||||
    test "it rejects objects when attributedTo is wrong (variant 1)" do
 | 
			
		||||
      {:error, _} = Fetcher.fetch_object_from_id("https://info.pleroma.site/activity2.json")
 | 
			
		||||
 | 
			
		||||
      refute called(Pleroma.Web.OStatus.fetch_activity_from_url(:_))
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    test_with_mock "it rejects objects when attributedTo is wrong (variant 2)",
 | 
			
		||||
                   Pleroma.Web.OStatus,
 | 
			
		||||
                   [:passthrough],
 | 
			
		||||
                   [] do
 | 
			
		||||
    test "it rejects objects when attributedTo is wrong (variant 2)" do
 | 
			
		||||
      {:error, _} = Fetcher.fetch_object_from_id("https://info.pleroma.site/activity3.json")
 | 
			
		||||
 | 
			
		||||
      refute called(Pleroma.Web.OStatus.fetch_activity_from_url(:_))
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue