More resilient xml parsing.

This commit is contained in:
Roger Braun 2017-06-24 14:35:32 +02:00
parent 6935fc3e01
commit 39bacba280
3 changed files with 15 additions and 5 deletions

View File

@ -30,6 +30,7 @@ defmodule Pleroma.Web.OStatus do
activities = Enum.map(entries, fn (entry) ->
{:xmlObj, :string, object_type} = :xmerl_xpath.string('string(/entry/activity:object-type[1])', entry)
{:xmlObj, :string, verb} = :xmerl_xpath.string('string(/entry/activity:verb[1])', entry)
Logger.debug("Handling #{verb}")
case verb do
'http://activitystrea.ms/schema/1.0/follow' ->

View File

@ -98,7 +98,7 @@ defmodule Pleroma.Web.WebFinger do
end
with {:ok, %{status_code: status_code, body: body}} when status_code in 200..299 <- response,
doc <- XML.parse_document(body),
doc when doc != :error<- XML.parse_document(body),
{:ok, data} <- webfinger_from_xml(doc) do
{:ok, data}
else

View File

@ -1,4 +1,7 @@
defmodule Pleroma.Web.XML do
require Logger
def string_from_xpath(xpath, :error), do: nil
def string_from_xpath(xpath, doc) do
{:xmlObj, :string, res} = :xmerl_xpath.string('string(#{xpath})', doc)
@ -10,10 +13,16 @@ defmodule Pleroma.Web.XML do
end
def parse_document(text) do
{doc, _rest} = text
|> :binary.bin_to_list
|> :xmerl_scan.string
try do
{doc, _rest} = text
|> :binary.bin_to_list
|> :xmerl_scan.string
doc
doc
catch
:exit, error ->
Logger.debug("Couldn't parse xml: #{inspect(text)}")
:error
end
end
end