telemetry: expose stats about failed deliveries

And also log about it which we so far didn't do
This commit is contained in:
Oneric 2025-03-01 20:37:06 +01:00
parent 2fee79e1f5
commit 1f6f5edf85

View file

@ -3,6 +3,7 @@ defmodule Pleroma.Web.Telemetry do
import Telemetry.Metrics import Telemetry.Metrics
alias Pleroma.Stats alias Pleroma.Stats
alias Pleroma.Config alias Pleroma.Config
require Logger
def start_link(arg) do def start_link(arg) do
Supervisor.start_link(__MODULE__, arg, name: __MODULE__) Supervisor.start_link(__MODULE__, arg, name: __MODULE__)
@ -10,6 +11,8 @@ def start_link(arg) do
@impl true @impl true
def init(_arg) do def init(_arg) do
subscribe_to_events()
children = children =
[ [
{:telemetry_poller, measurements: periodic_measurements(), period: 10_000} {:telemetry_poller, measurements: periodic_measurements(), period: 10_000}
@ -32,6 +35,82 @@ defp prometheus_children do
end end
end end
defp subscribe_to_events() do
# note: all handlers for a event are executed blockingly
# before the event can conclude, so they mustn't do anything heavy
:telemetry.attach(
"akkoma-oban-jobs-stop",
[:oban, :job, :stop],
&__MODULE__.handle_lib_event/4,
[]
)
:telemetry.attach(
"akkoma-oban-jobs-fail",
[:oban, :job, :exception],
&__MODULE__.handle_lib_event/4,
[]
)
end
def handle_lib_event(
[:oban, :job, event],
_measurements,
%{state: :discard, worker: "Pleroma.Workers.PublisherWorker"} = meta,
_config
)
when event in [:stop, :exception] do
{full_target, simple_target, reason} =
case meta.args["op"] do
"publish" ->
{meta.args["activity_id"], nil, "inbox_collection"}
"publish_one" ->
full_target = get_in(meta.args, ["params", "inbox"])
%{host: simple_target} = URI.parse(full_target || "")
error = collect_apdelivery_error(event, meta)
{full_target, simple_target, error}
end
Logger.error("Failed AP delivery: #{inspect(reason)} for #{inspect(full_target)}")
:telemetry.execute([:akkoma, :ap, :delivery, :fail], %{final: 1}, %{
reason: reason,
target: simple_target
})
end
def handle_lib_event([:oban, :job, _], _, _, _), do: :ok
defp collect_apdelivery_error(:exception, %{result: nil, reason: reason}) do
case reason do
%Oban.CrashError{} -> "crash"
%Oban.TimeoutError{} -> "timeout"
%type{} -> "exception_#{type}"
end
end
defp collect_apdelivery_error(:exception, %{result: {:error, error}}) do
process_fail_reason(error)
end
defp collect_apdelivery_error(:stop, %{result: {_, reason}}) do
process_fail_reason(reason)
end
defp collect_apdelivery_error(_, _) do
"cause_unknown"
end
defp process_fail_reason(error) do
case error do
error when is_binary(error) -> error
error when is_atom(error) -> "#{error}"
%{status: code} when is_number(code) -> "http_#{code}"
_ -> "error_unknown"
end
end
# A seperate set of metrics for distributions because phoenix dashboard does NOT handle them well # A seperate set of metrics for distributions because phoenix dashboard does NOT handle them well
defp distribution_metrics do defp distribution_metrics do
[ [
@ -215,7 +294,8 @@ defp common_metrics(byte_unit \\ :byte) do
last_value("pleroma.local_users.total"), last_value("pleroma.local_users.total"),
last_value("pleroma.domains.total"), last_value("pleroma.domains.total"),
last_value("pleroma.local_statuses.total"), last_value("pleroma.local_statuses.total"),
last_value("pleroma.remote_users.total") last_value("pleroma.remote_users.total"),
counter("akkoma.ap.delivery.fail.final", tags: [:target, :reason])
] ]
end end